-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66637/#review201234
-----------------------------------------------------------
Ship it!
Thanks again for the cleanup!
Just a random comment, we could start doing:
```
*task.mutable_container() = createDockerInfo("alpine");
```
Instead of:
```
task.mutable_container()->CopyFrom(createDockerInfo("alpine"));
```
But that would not be consistent with what we do in most places in our tests,
so I didn't open an issue =).
- Gaston Kleiman
On April 16, 2018, 10:31 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66637/
> -----------------------------------------------------------
>
> (Updated April 16, 2018, 10:31 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Gaston Kleiman, Greg Mann, and
> Zhitao Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Docker containerizer tests all create a Docker `ContainerInfo`.
> We can reduce the amount of copy/paste boilerplate by adding a
> simple helper function to create a `ContainerInfo` with a Docker
> image.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp
> 847258daadf3c37d9071151616b18fc79d850ce8
>
>
> Diff: https://reviews.apache.org/r/66637/diff/2/
>
>
> Testing
> -------
>
> sudo make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
