-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/#review201623
-----------------------------------------------------------
This does currently not configure for me with `ENABLE_GRPC` (for the Ninja
generator):
CMake Error at 3rdparty/CMakeLists.txt:177 (get_target_property):
INTERFACE_LIBRARY targets may only have whitelisted properties. The
property "IMPORTED_LOCATION" is not allowed.
Call Stack (most recent call first):
3rdparty/CMakeLists.txt:1112 (GET_BYPRODUCTS)
- Benjamin Bannier
On April 20, 2018, 4:28 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61096/
> -----------------------------------------------------------
>
> (Updated April 20, 2018, 4:28 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and
> Joseph Wu.
>
>
> Bugs: MESOS-7881
> https://issues.apache.org/jira/browse/MESOS-7881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
> 3rdparty library in CMake.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt e6bb4076e630d78e73a82a93b1f64b3bc5d859b9
> 3rdparty/cmake/Versions.cmake 33577cc86d3ef31e129b8ea55d44d3fee02d4a30
> cmake/CompilationConfigure.cmake 173089a1ebf80a6288431075770a807235524ac1
> src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc
>
>
> Diff: https://reviews.apache.org/r/61096/diff/9/
>
>
> Testing
> -------
>
> `cmake .. -DENABLE_GRPC=1` then `cmake --build .` on both Linux and Windows.
>
> NOTE: libprocess-tests will be failed to build on Windows with VS. This is
> fixed in the next patch.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
