----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66733/#review201680 -----------------------------------------------------------
Fix it, then Ship it! src/tests/master_tests.cpp Lines 5047-5051 (original), 5047-5052 (patched) <https://reviews.apache.org/r/66733/#comment283213> Let's update the comment and use string literals (http://en.cppreference.com/w/cpp/language/string_literal): ``` // Agents should have the following capabilities in the current // implementation. Try<JSON::Value> expectedCapabilities = JSON::parse( R"~( [ "MULTI_ROLE", "HIERARCHICAL_ROLE", "RESERVATION_REFINEMENT", "RESOURCE_PROVIDER", "RESIZE_VOLUME" ] )~"); ``` src/tests/slave_tests.cpp Lines 1614-1619 (original), 1614-1619 (patched) <https://reviews.apache.org/r/66733/#comment283214> Ditto. - Chun-Hung Hsiao On April 20, 2018, 6:38 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66733/ > ----------------------------------------------------------- > > (Updated April 20, 2018, 6:38 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4945 > https://issues.apache.org/jira/browse/MESOS-4945 > > > Repository: mesos > > > Description > ------- > > This will be used as a feature flag to gate the new volume resize > feature. This feature will be turn on by default once released. > > > Diffs > ----- > > include/mesos/mesos.proto 9e24d3ea46edc21572e9226e2e76c7d55618db24 > include/mesos/v1/mesos.proto 0f3fd8a2608b5edabc21f5fe5df9b70fc0fa8dc2 > src/common/protobuf_utils.hpp ae060f3a7946ac5862faeca15330e9642f934137 > src/common/protobuf_utils.cpp 141a444534b776a2c90e2a0daf9727cd21e39080 > src/slave/constants.cpp 51de71bc45ff4fb862690efd9428b25d92055391 > src/tests/master_tests.cpp be7a3cc6126d2fe7c56c49b3da5f6f4bf29657f5 > src/tests/slave_tests.cpp 04f7acad47aa980d507bbe29b29db5eb050c02f3 > > > Diff: https://reviews.apache.org/r/66733/diff/1/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
