-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66568/
-----------------------------------------------------------
(Updated April 23, 2018, 1:07 p.m.)
Review request for mesos, Chun-Hung Hsiao and Greg Mann.
Changes
-------
Make sure dropReason is set.
Bugs: MESOS-4965
https://issues.apache.org/jira/browse/MESOS-4965
Repository: mesos
Description
-------
These two operations are intended to be non-speculative eventually but
are implemented as speculative right now. To avoid frameworks opt-in to
dangerous behavior, we require that accept can only contain one
`GROW_VOLUME` or `SHRINK_VOLUME` and no other operations.
This is implemented by reuse existing code which already drops `LAUNCH`
or `LAUNCH_GROUP` with proper reason and message.
Diffs (updated)
-----
src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a
Diff: https://reviews.apache.org/r/66568/diff/5/
Changes: https://reviews.apache.org/r/66568/diff/4-5/
Testing
-------
Behavior tested in https://reviews.apache.org/r/66569/.
Thanks,
Zhitao Li
