----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/#review202147 -----------------------------------------------------------
Fix it, then Ship it! src/resource_provider/storage/provider.cpp Lines 2869-2871 (patched) <https://reviews.apache.org/r/66049/#comment283778> ``` case Offer::Operation::GROW_VOLUME: case Offer::Operation::SHRINK_VOLUME: { // TODO(zhitao): These operations are currently not supported for // resource providers, and should have been validated by the master. UNIMPLEMENTED; } ``` And also include `stout/unimplemented.hpp`. Or you can leave my id (`chhsiao`) here instead. - Chun-Hung Hsiao On April 27, 2018, 7:23 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66049/ > ----------------------------------------------------------- > > (Updated April 27, 2018, 7:23 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > Added offer operation to grow and shrink persistent volumes. > > > Diffs > ----- > > include/mesos/mesos.proto 5bc4a80ad5278d20feced73dce755519515de505 > include/mesos/v1/mesos.proto 5a4e733250831fa5fe86544aeb98dbc0a4f5afa6 > src/common/protobuf_utils.cpp 78bffd8595f0e9f34e981548d8136ff94160573b > src/common/resources_utils.cpp 9be01c1abd48264e308960f35cc7c2ee8a367518 > src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 > src/resource_provider/storage/provider.cpp > 8ca2d3a98858940e6e027becefb53c2f00b4ae43 > src/tests/mesos.hpp 756a52189ea3336b203ea1d606e2ba17762d57aa > src/tests/persistent_volume_tests.cpp > 4edf781711d9efdb994114aeb6289b6af750b87a > src/tests/reservation_tests.cpp 5570df2e0b208512d0a0a3079a180e1acfe08f3d > > > Diff: https://reviews.apache.org/r/66049/diff/12/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
