----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66283/#review202152 -----------------------------------------------------------
Fix it, then Ship it! src/docker/executor.cpp Lines 418 (patched) <https://reviews.apache.org/r/66283/#comment283818> As discussed on chat, we probably don't need to log here, just return if we already made the state transition. src/docker/executor.cpp Lines 420 (patched) <https://reviews.apache.org/r/66283/#comment283790> Two many newlines :) src/docker/executor.cpp Lines 422 (patched) <https://reviews.apache.org/r/66283/#comment283784> ``` " which exceeded its ..." ``` src/docker/executor.cpp Lines 427 (patched) <https://reviews.apache.org/r/66283/#comment283788> Nits: capitalize this sentence and add a blank line above it. src/docker/executor.cpp Lines 575 (patched) <https://reviews.apache.org/r/66283/#comment283785> This should be `!killedByTaskCompletionTimeout`, right? - James Peach On April 23, 2018, 10:25 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66283/ > ----------------------------------------------------------- > > (Updated April 23, 2018, 10:25 p.m.) > > > Review request for mesos, Jason Lai and James Peach. > > > Bugs: MESOS-8725 > https://issues.apache.org/jira/browse/MESOS-8725 > > > Repository: mesos > > > Description > ------- > > If `TaskInfo.max_completion_time` is set, docker executor will kill > the task immediately. We reuse the `shutdown` method to achieve a > forced kill ignoring any `KillPolicy`. > > Framework should only received a `TASK_FAILED` state with > `REASON_MAX_COMPLETION_TIME_REACHED` reason. > > > Diffs > ----- > > src/docker/executor.cpp 1d672112bae889cc9d19343a59e0ff66569785c4 > > > Diff: https://reviews.apache.org/r/66283/diff/4/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
