----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66644/#review202215 -----------------------------------------------------------
LGTM sans the unresolved issue from the previous revision! src/tests/partition_tests.cpp Lines 167-169 (original), 167-170 (patched) <https://reviews.apache.org/r/66644/#comment283966> This reads like "the `RunTaskMessage` is remove correctly" but I think the subject is the `task`? Perhaps revise a bit so it says ``` // This test verifies that if a `RunTaskMessage` dropped en route to // an agent which later becomes unreachable, the task is removed correctly // from the master's unreachable task records when the agent // reregisters. ``` ? src/tests/partition_tests.cpp Lines 171 (patched) <https://reviews.apache.org/r/66644/#comment283967> This seems to be exceeded the 80 character limit. src/tests/partition_tests.cpp Lines 47 (patched) <https://reviews.apache.org/r/66644/#comment283968> It doesn't look like this is used? - Jiang Yan Xu On April 25, 2018, 8:46 a.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66644/ > ----------------------------------------------------------- > > (Updated April 25, 2018, 8:46 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: 8750 > https://issues.apache.org/jira/browse/8750 > > > Repository: mesos > > > Description > ------- > > A RunTask messsage could get dropped for an agent while it's > disconnected from the master and when such an agent goes unreachable > then this dropped task gets added to the unreachable tasks. > When the agent reregisters, tasks reported by it are removed from the > unreachableTasks bookkeeping on the master but since the > agent doesn't know about the dropped task so it doesn't get removed > from the unreachableTasks leading to a master check failure when > this inconsistency is detected during framework removal. > > > Diffs > ----- > > src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 > src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a > src/tests/partition_tests.cpp 9138e5c745cf354a3573e1ab0b251d46702833cc > > > Diff: https://reviews.apache.org/r/66644/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Megha Sharma > >
