----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66644/#review202368 -----------------------------------------------------------
Fix it, then Ship it! I'll commit with these minor fixes. src/master/master.hpp Lines 1928 (patched) <https://reviews.apache.org/r/66644/#comment284232> I'll quote the `unreachable` as it is code. src/master/master.cpp Lines 7131 (patched) <https://reviews.apache.org/r/66644/#comment284170> Space in between `foreachkey (` src/master/master.cpp Lines 7135 (patched) <https://reviews.apache.org/r/66644/#comment284171> Space in between `foreach (` src/tests/partition_tests.cpp Lines 168-169 (patched) <https://reviews.apache.org/r/66644/#comment284231> This clearly can fit in the previous line which would be less jagged. src/tests/partition_tests.cpp Lines 396 (patched) <https://reviews.apache.org/r/66644/#comment284230> Period to end the sentence. - Jiang Yan Xu On May 1, 2018, 10:18 p.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66644/ > ----------------------------------------------------------- > > (Updated May 1, 2018, 10:18 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: 8750 > https://issues.apache.org/jira/browse/8750 > > > Repository: mesos > > > Description > ------- > > A RunTask messsage could get dropped for an agent while its > disconnected from the master and when such an agent goes unreachable > then this dropped task message gets added to the unreachable tasks. > When the agent reregisters, the master sends status updates for the > tasks that the agent reported when re-registering and these tasks are > also removed from the unreachableTasks on the framework but since the > agent doesn't know about the dropped task so it doesn't get removed > from the unreachableTasks leading to a check failure when > this inconsistency is detected during framework removal. > > > Diffs > ----- > > src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 > src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a > src/tests/partition_tests.cpp 9138e5c745cf354a3573e1ab0b251d46702833cc > > > Diff: https://reviews.apache.org/r/66644/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Megha Sharma > >
