----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66885/#review202262 -----------------------------------------------------------
Ship it! Thanks for fixing these. I looked why we missed these with `mesos-tidy`'s `mesos-redundant-get` check and left comments below. I created e.g., https://issues.apache.org/jira/browse/MESOS-8864 to add the XFS disk isolator to the cmake build. src/cli/resolve.cpp Line 121 (original), 121 (patched) <https://reviews.apache.org/r/66885/#comment284014> This wasn't found by the linter since the old CLI is not built as a part of cmake. Since the new CLI is, I did not create an issue to add it. src/java/jni/org_apache_mesos_Log.cpp Line 369 (original), 369 (patched) <https://reviews.apache.org/r/66885/#comment284028> The JNI bindings are not checked with `mesos-tidy`. This might make sense as they are mostly static, but building the required files takes a lot of time. I confirmed that with this fix all JNI files visible under Linux are fixed for `->` vs. `get`. I filed https://issues.apache.org/jira/browse/MESOS-8865 along the way. src/linux/routing/diagnosis/diagnosis.cpp Line 68 (original), 68 (patched) <https://reviews.apache.org/r/66885/#comment284016> https://issues.apache.org/jira/browse/MESOS-8863 src/linux/routing/filter/icmp.cpp Line 102 (original), 102 (patched) <https://reviews.apache.org/r/66885/#comment284017> https://issues.apache.org/jira/browse/MESOS-8863 src/linux/routing/filter/internal.hpp Line 124 (original), 124 (patched) <https://reviews.apache.org/r/66885/#comment284018> https://issues.apache.org/jira/browse/MESOS-8863 src/linux/routing/filter/ip.cpp Line 159 (original), 159 (patched) <https://reviews.apache.org/r/66885/#comment284019> https://issues.apache.org/jira/browse/MESOS-8863 src/linux/routing/link/internal.hpp Line 67 (original), 67 (patched) <https://reviews.apache.org/r/66885/#comment284020> https://issues.apache.org/jira/browse/MESOS-8863 src/linux/routing/link/link.cpp Line 135 (original), 135 (patched) <https://reviews.apache.org/r/66885/#comment284021> https://issues.apache.org/jira/browse/MESOS-8863 src/linux/routing/link/veth.cpp Line 46 (original), 46 (patched) <https://reviews.apache.org/r/66885/#comment284022> https://issues.apache.org/jira/browse/MESOS-8863 src/linux/routing/route.cpp Line 57 (original), 57 (patched) <https://reviews.apache.org/r/66885/#comment284015> https://issues.apache.org/jira/browse/MESOS-8863 src/slave/containerizer/mesos/isolators/network/port_mapping.cpp Line 1094 (original), 1094 (patched) <https://reviews.apache.org/r/66885/#comment284023> https://issues.apache.org/jira/browse/MESOS-8863 src/slave/containerizer/mesos/isolators/windows/cpu.cpp Line 215 (original), 215 (patched) <https://reviews.apache.org/r/66885/#comment284024> We sadly do not have an automated tidy bot for Windows ATM, thanks for fixing these. src/slave/containerizer/mesos/isolators/windows/mem.cpp Line 213 (original), 213 (patched) <https://reviews.apache.org/r/66885/#comment284025> We sadly do not have an automated tidy bot for Windows ATM, thanks for fixing these. src/slave/containerizer/mesos/isolators/xfs/disk.cpp Line 143 (original), 143 (patched) <https://reviews.apache.org/r/66885/#comment284026> https://issues.apache.org/jira/browse/MESOS-8864 src/slave/containerizer/mesos/isolators/xfs/utils.cpp Line 158 (original), 158 (patched) <https://reviews.apache.org/r/66885/#comment284027> https://issues.apache.org/jira/browse/MESOS-8864 - Benjamin Bannier On May 1, 2018, 6:33 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66885/ > ----------------------------------------------------------- > > (Updated May 1, 2018, 6:33 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > In many cases, containers that have a `get()` accessor also have > a `->` operator that can be used to directly access their help > object. Replace `.get().` with `->` for improved consistency and > readability. > > > Diffs > ----- > > src/cli/resolve.cpp fe62f9fc569b77f6e5fb101ac7e2515a9f14d08a > src/java/jni/org_apache_mesos_Log.cpp > e5e632c0255c372e2ed5622940523bd1381b7b9c > src/linux/routing/diagnosis/diagnosis.cpp > 3e80a29427569180039719ded11194a0afc814b5 > src/linux/routing/filter/icmp.cpp 68a1c3486e3fceb7110769240fbca97e3325ef31 > src/linux/routing/filter/internal.hpp > b22a818517e98fecf5ddf96fd0fa2ed95ecde15d > src/linux/routing/filter/ip.cpp dd8cec7de680731ff626bf928c2f85eea2ef2b7a > src/linux/routing/link/internal.hpp > 12064076c017cb71f403625f209e463dbd49d82f > src/linux/routing/link/link.cpp 5388a3d4af11083f08b79e25d439cfe33252f1b8 > src/linux/routing/link/veth.cpp e12af9fd9d0874dd006b0ce1ade373bba259aa78 > src/linux/routing/queueing/internal.hpp > 9fe522ee017c86af8c7b2e518cd0957af08750e4 > src/linux/routing/route.cpp ba39eac3aa37244c5ca79f50423423e219b81450 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > 96e1a2b4133171e7a204e5d234c28ed81913261c > src/slave/containerizer/mesos/isolators/windows/cpu.cpp > 104e35d2cba072c08be1e0ec6074c1bd43464c87 > src/slave/containerizer/mesos/isolators/windows/mem.cpp > eb6c93e5657db3758325de9192e164da5935ec60 > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > db11f9a095dec0edcdded42d1d41ebcbad68db19 > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > cc14254f3711b81a0f93e9bef77bf81d651718b9 > > > Diff: https://reviews.apache.org/r/66885/diff/2/ > > > Testing > ------- > > make check (Fedora 27) > > > Thanks, > > James Peach > >
