----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66920/#review202355 -----------------------------------------------------------
src/tests/persistent_volume_tests.cpp Lines 604 (patched) <https://reviews.apache.org/r/66920/#comment284139> Technically we only tested that persistent volume and its data can still be accessed. I do not know a reliable and efficient way to test the volume size actually changed after resizing. Maybe clarify the comment? src/tests/persistent_volume_tests.cpp Line 751 (original), 807 (patched) <https://reviews.apache.org/r/66920/#comment284140> ``` This test verifies that launching any task depending either origial or grown volume of a `GROW_VOLUME` call in the same `acceptOffers` will be dropped... ``` src/tests/persistent_volume_tests.cpp Line 874 (original), 942 (patched) <https://reviews.apache.org/r/66920/#comment284141> ``` This test verifies that launching any task depending either origial or shrunk volume of a `SHRINK_VOLUME` call in the same `acceptOffers` will be dropped... ``` - Zhitao Li On May 2, 2018, 9:54 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66920/ > ----------------------------------------------------------- > > (Updated May 2, 2018, 9:54 p.m.) > > > Review request for mesos, Greg Mann and Zhitao Li. > > > Repository: mesos > > > Description > ------- > > Now the `GrowVolume` and `ShrinkVolume` tests launch tasks after > resizing the volumes to ensure that the operations take effect on > agents. The `NonSpeculativeGrowAndLaunch` and > `NonSpeculativeShrinkAndLaunch` tests launch an additional task to > verify that the original volume consumed by the operations cannot be > used by subsequent tasks. > > This patch also adjusted when the clock is resumed so schedulers will > not receive unexpected offers. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > 4edf781711d9efdb994114aeb6289b6af750b87a > > > Diff: https://reviews.apache.org/r/66920/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
