----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66920/#review202393 -----------------------------------------------------------
Fix it, then Ship it! src/tests/persistent_volume_tests.cpp Lines 845 (patched) <https://reviews.apache.org/r/66920/#comment284202> s/keep/make/ src/tests/persistent_volume_tests.cpp Lines 981 (patched) <https://reviews.apache.org/r/66920/#comment284203> s/keep/make/ - Greg Mann On May 3, 2018, 8:55 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66920/ > ----------------------------------------------------------- > > (Updated May 3, 2018, 8:55 p.m.) > > > Review request for mesos, Greg Mann and Zhitao Li. > > > Repository: mesos > > > Description > ------- > > Now the `GrowVolume` and `ShrinkVolume` tests launch tasks after > resizing the volumes to ensure that the operations take effect on > agents. The `NonSpeculativeGrowAndLaunch` and > `NonSpeculativeShrinkAndLaunch` tests launch an additional task to > verify that the original volume consumed by the operations cannot be > used by subsequent tasks. > > This patch also adjusted when the clock is resumed so schedulers will > not receive unexpected offers. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > 4edf781711d9efdb994114aeb6289b6af750b87a > > > Diff: https://reviews.apache.org/r/66920/diff/3/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
