----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66938/#review202388 -----------------------------------------------------------
src/sched/sched.cpp Lines 1349-1352 (patched) <https://reviews.apache.org/r/66938/#comment284199> We should call `error()` here so that the framework is gracefully teared down instead of triggering a segfault. - Gaston Kleiman On May 3, 2018, 3:07 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66938/ > ----------------------------------------------------------- > > (Updated May 3, 2018, 3:07 p.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jan Schlicht, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Since the 'SchedulerDriver' does not support operation status updates, > this patch adds a CHECK to the driver which will abort the scheduler > if the 'id' field is set in an offer operation. > > This patch also removes the test > 'SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework' > because with these new changes, it causes the test harness to abort. > > > Diffs > ----- > > src/sched/sched.cpp 620a3b26d8bf3487b6ce922b2280be7da291df06 > src/tests/scheduler_tests.cpp 749420a23bc1a3873bd4d5aee56e78cff79bb1af > > > Diff: https://reviews.apache.org/r/66938/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > >
