> On May 3, 2018, 10:25 p.m., Gaston Kleiman wrote: > > src/sched/sched.cpp > > Lines 1349-1352 (patched) > > <https://reviews.apache.org/r/66938/diff/1/?file=2016592#file2016592line1349> > > > > We should call `error()` here so that the framework is gracefully > > teared down instead of triggering a segfault.
Good call, thanks! This also allows us to keep the existing test. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66938/#review202388 ----------------------------------------------------------- On May 3, 2018, 11:14 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66938/ > ----------------------------------------------------------- > > (Updated May 3, 2018, 11:14 p.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jan Schlicht, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Since the 'SchedulerDriver' does not support operation status updates, > this patch adds a check to the driver which will abort the scheduler > if the 'id' field is set in an offer operation. > > > Diffs > ----- > > src/sched/sched.cpp 620a3b26d8bf3487b6ce922b2280be7da291df06 > > > Diff: https://reviews.apache.org/r/66938/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > >
