----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66962/#review202479 -----------------------------------------------------------
3rdparty/stout/tests/os/filesystem_tests.cpp Lines 724-729 (patched) <https://reviews.apache.org/r/66962/#comment284299> I believe definitions for read_async/write_async might not be in master as yet. Would this break the build? 3rdparty/stout/tests/os/filesystem_tests.cpp Lines 769 (patched) <https://reviews.apache.org/r/66962/#comment284300> Does this really block? Then execution would not proceed to read_async? - Radhika Jandhyala On May 4, 2018, 5:27 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66962/ > ----------------------------------------------------------- > > (Updated May 4, 2018, 5:27 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-8670 > https://issues.apache.org/jira/browse/MESOS-8670 > > > Repository: mesos > > > Description > ------- > > New asynchronous functions were introduced to the Windows stout read > and write implementations, so eztra tests were added. > > > Diffs > ----- > > 3rdparty/stout/tests/os/filesystem_tests.cpp > b17ab9aaa94ae14b6707a9ac7a54b9db38615f2a > > > Diff: https://reviews.apache.org/r/66962/diff/1/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
