----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66962/#review203650 -----------------------------------------------------------
Patch looks great! Reviews applied: [67248, 66952, 66954, 66955, 66956, 66957, 66958, 66959, 66960, 66961, 66962] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 22, 2018, 10:55 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66962/ > ----------------------------------------------------------- > > (Updated May 22, 2018, 10:55 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-8670 > https://issues.apache.org/jira/browse/MESOS-8670 > > > Repository: mesos > > > Description > ------- > > New asynchronous functions were introduced to the Windows stout read > and write implementations, so eztra tests were added. > > > Diffs > ----- > > 3rdparty/stout/tests/os/filesystem_tests.cpp > b17ab9aaa94ae14b6707a9ac7a54b9db38615f2a > > > Diff: https://reviews.apache.org/r/66962/diff/2/ > > > Testing > ------- > > Ran stout/libprocess/mesos-tests on Windows. Ran make check on Linux. > > > Thanks, > > Akash Gupta > >
