----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66959/#review202495 -----------------------------------------------------------
Ship it! Ship It! src/slave/containerizer/mesos/containerizer.cpp Lines 1864 (patched) <https://reviews.apache.org/r/66959/#comment284308> Would this mean that on windows process launched by the containerizer would not be able to perform async io? - Radhika Jandhyala On May 4, 2018, 5:19 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66959/ > ----------------------------------------------------------- > > (Updated May 4, 2018, 5:19 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-8674 > https://issues.apache.org/jira/browse/MESOS-8674 > > > Repository: mesos > > > Description > ------- > > The Mesos containerizer needs an inheritable pipe that is not used for > stdio of the child process. It is used for signaling when the child > process should start running, so the pipe needs to be inheritable and > not overlapped. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 01386ac3d36ec7a401b8d1be7834bc1f3fce55ef > > > Diff: https://reviews.apache.org/r/66959/diff/1/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
