----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66959/#review203695 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp Lines 1874-1878 (patched) <https://reviews.apache.org/r/66959/#comment285966> NOTE: This will likely be changed soon to go back to non-inheritable, as Radhika's chain is plumbing through the work to pass this pipe explicitly (through args, so we can whitelist it) instead of implicitly (through environment variables). But it is as it should be for now. - Andrew Schwartzmeyer On May 4, 2018, 10:19 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66959/ > ----------------------------------------------------------- > > (Updated May 4, 2018, 10:19 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-8674 > https://issues.apache.org/jira/browse/MESOS-8674 > > > Repository: mesos > > > Description > ------- > > The Mesos containerizer needs an inheritable pipe that is not used for > stdio of the child process. It is used for signaling when the child > process should start running, so the pipe needs to be inheritable and > not overlapped. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > eac1d16f2388385fec04ff8f013ce0ebf4e97f0f > > > Diff: https://reviews.apache.org/r/66959/diff/2/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
