-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67041/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and
Radhika Jandhyala.
Bugs: MESOS-3442
https://issues.apache.org/jira/browse/MESOS-3442
Repository: mesos
Description
-------
This port does not attempt to use `path::join()` to avoid duplicated
test logic since that function strips the path separator from its
arguments, thus making it difficult to correctly construct a path like
`a//b/`. Instead, a semi-programatical approach was taken to duplicate
the POSIX paths and then replace `/` with `\`.
Diffs
-----
3rdparty/stout/tests/path_tests.cpp 433a6c60bb6991410e54ab6a6dcd2499c664c37b
Diff: https://reviews.apache.org/r/67041/diff/1/
Testing
-------
```
./3rdparty/stout/tests/stout-tests.exe --gtest_filter="PathTest.*"
Note: Google Test filter = PathTest.*-
[==========] Running 7 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 7 tests from PathTest
[ RUN ] PathTest.Basename
[ OK ] PathTest.Basename (1 ms)
[ RUN ] PathTest.Dirname
[ OK ] PathTest.Dirname (0 ms)
[ RUN ] PathTest.Extension
[ OK ] PathTest.Extension (0 ms)
[ RUN ] PathTest.Join
[ OK ] PathTest.Join (1 ms)
[ RUN ] PathTest.Absolute
[ OK ] PathTest.Absolute (0 ms)
[ RUN ] PathTest.Comparison
[ OK ] PathTest.Comparison (0 ms)
[ RUN ] PathTest.FromURI
[ OK ] PathTest.FromURI (0 ms)
[----------] 7 tests from PathTest (2 ms total)
[----------] Global test environment tear-down
[==========] 7 tests from 1 test case ran. (2 ms total)
[ PASSED ] 7 tests.
3rdparty/stout/tests/stout-tests --gtest_filter="PathTest.*"
Note: Google Test filter = PathTest.*-
[==========] Running 7 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 7 tests from PathTest
[ RUN ] PathTest.Basename
[ OK ] PathTest.Basename (0 ms)
[ RUN ] PathTest.Dirname
[ OK ] PathTest.Dirname (0 ms)
[ RUN ] PathTest.Extension
[ OK ] PathTest.Extension (0 ms)
[ RUN ] PathTest.Join
[ OK ] PathTest.Join (0 ms)
[ RUN ] PathTest.Absolute
[ OK ] PathTest.Absolute (0 ms)
[ RUN ] PathTest.Comparison
[ OK ] PathTest.Comparison (0 ms)
[ RUN ] PathTest.FromURI
[ OK ] PathTest.FromURI (0 ms)
[----------] 7 tests from PathTest (0 ms total)
[----------] Global test environment tear-down
[==========] 7 tests from 1 test case ran. (0 ms total)
[ PASSED ] 7 tests.
```
Thanks,
Andrew Schwartzmeyer
