----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66670/#review202828 -----------------------------------------------------------
src/slave/containerizer/composing.cpp Line 599 (original), 599-602 (patched) <https://reviews.apache.org/r/66670/#comment284825> Can you please let me know in which case we can reach here for a nested container? It seems we will only call `containerizer->destroy()` to destroy a nested containers in `Http::_launchContainer()` and `Http::launchNestedContainerSession()`, for both of them, the nested container should still be in `containers_` when they call `containerizer->destroy()`, but we can only reach here for the containers which are not in `containers_`. src/slave/containerizer/composing.cpp Line 621 (original), 629-632 (patched) <https://reviews.apache.org/r/66670/#comment284813> Similarly, I am wondering if we can reach here for a nested container. If a nested container terminates but has not been removed from `containers_`, then it should be still in the `LAUNCHED` state, but we can only reach here for the containers in the `DESTROYING` state. - Qian Zhang On April 17, 2018, 11:23 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66670/ > ----------------------------------------------------------- > > (Updated April 17, 2018, 11:23 p.m.) > > > Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian > Zhang. > > > Bugs: MESOS-8713 > https://issues.apache.org/jira/browse/MESOS-8713 > > > Repository: mesos > > > Description > ------- > > We need to return the same `ContainerTermination` result for both > `wait()` and `destroy()` for a terminated container. This patch > ensures that for a terminated nested container `destroy()` returns > the same result as for `wait()`. > > > Diffs > ----- > > src/slave/containerizer/composing.cpp > 186102c66d373dcd799cadd9fed7d1c8cb894971 > src/slave/containerizer/mesos/containerizer.cpp > 01386ac3d36ec7a401b8d1be7834bc1f3fce55ef > > > Diff: https://reviews.apache.org/r/66670/diff/2/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >
