----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/#review203264 -----------------------------------------------------------
src/master/master.hpp Lines 2993 (patched) <https://reviews.apache.org/r/66819/#comment285367> I think this CHECK will fail when a scheduler subscribes for the first time? Check out this callsite: https://github.com/apache/mesos/blob/eb9ab8089ae9bcb5779454fb2a6ce18b51a9a0cb/src/master/master.cpp#L2688 - Greg Mann On May 16, 2018, 12:33 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66819/ > ----------------------------------------------------------- > > (Updated May 16, 2018, 12:33 a.m.) > > > Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jie Yu, > and Vinod Kone. > > > Bugs: MESOS-8919 > https://issues.apache.org/jira/browse/MESOS-8919 > > > Repository: mesos > > > Description > ------- > > Added FrameworkMetrics struct in framework struct. > > > Diffs > ----- > > src/master/master.hpp 5ec764b5c7f96bab786084cccf20fd8a17319718 > src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b > src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 > > > Diff: https://reviews.apache.org/r/66819/diff/5/ > > > Testing > ------- > > > Thanks, > > Gilbert Song > >
