-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67158/#review203322
-----------------------------------------------------------


Fix it, then Ship it!





src/csi/client.cpp
Lines 31-38 (original), 31-38 (patched)
<https://reviews.apache.org/r/67158/#comment285439>

    Maybe more a personal preference, but I preferred the previous wrapping 
with `.call` and `.then` on their own lines (I'd value being able to 
consistently and quickly follow the flow higher than being able to always list 
args to `call` on one line).
    
    Here and below.
    
    Feel free to drop if you disagree.



src/csi/client.cpp
Lines 35-40 (original), 35-40 (patched)
<https://reviews.apache.org/r/67158/#comment285440>

    This looks much better now!


- Benjamin Bannier


On May 16, 2018, 9:28 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67158/
> -----------------------------------------------------------
> 
> (Updated May 16, 2018, 9:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and 
> Zhitao Li.
> 
> 
> Bugs: MESOS-8924
>     https://issues.apache.org/jira/browse/MESOS-8924
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes the following changes:
> 1. Replace `GRPC_RPC` with `GRPC_CLIENT_METHOD`.
> 2. Replace `process::grpc::Channel` with
>    `process::grpc::client::Connection`.
> 3. Make the CSI client metods return a `Future` of a `Try`.
> 
> 
> Diffs
> -----
> 
>   src/csi/client.hpp 5d846740f72125efb3654e14d763bd24634367b9 
>   src/csi/client.cpp 559e8057eccce5bf758918c24e5ca8c561af6592 
>   src/tests/csi_client_tests.cpp f5b9eac38a4079cc2873ce2e2de24eaf315e0bc9 
>   src/tests/mock_csi_plugin.hpp 6f7a5ab327875c0277b4e73ea9500d0fbaea8034 
>   src/tests/mock_csi_plugin.cpp 6983b842aeede917599bfb711197738b95856fe1 
> 
> 
> Diff: https://reviews.apache.org/r/67158/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Reply via email to