-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67158/
-----------------------------------------------------------

(Updated May 17, 2018, 7:38 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Zhitao 
Li.


Changes
-------

Addressed Benjamin's comments.


Bugs: MESOS-8924
    https://issues.apache.org/jira/browse/MESOS-8924


Repository: mesos


Description
-------

This patch makes the following changes:
1. Replace `GRPC_RPC` with `GRPC_CLIENT_METHOD`.
2. Replace `process::grpc::Channel` with
   `process::grpc::client::Connection`.
3. Make the CSI client metods return a `Future` of a `Try`.


Diffs (updated)
-----

  src/csi/client.hpp 5d846740f72125efb3654e14d763bd24634367b9 
  src/csi/client.cpp 559e8057eccce5bf758918c24e5ca8c561af6592 
  src/tests/csi_client_tests.cpp f5b9eac38a4079cc2873ce2e2de24eaf315e0bc9 
  src/tests/mock_csi_plugin.hpp 6f7a5ab327875c0277b4e73ea9500d0fbaea8034 
  src/tests/mock_csi_plugin.cpp 6983b842aeede917599bfb711197738b95856fe1 


Diff: https://reviews.apache.org/r/67158/diff/2/

Changes: https://reviews.apache.org/r/67158/diff/1-2/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao

Reply via email to