-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67188/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and
Radhika Jandhyala.
Bugs: MESOS-8931
https://issues.apache.org/jira/browse/MESOS-8931
Repository: mesos
Description
-------
Once implemented, the tests had to be fixed to use Windows commands,
and a test that ensures `os::shell` doesn't hang was added. The
implementation does not reuse `os::spawn` because it must read all the
child process's piped output before waiting on it to exit, otherwise
it will deadlock.
Diffs
-----
3rdparty/stout/include/stout/os/windows/shell.hpp
8da612af2888ff4d4d458ea5b16cdb08779b6f4c
3rdparty/stout/tests/os_tests.cpp 419879a47eb14813b8c6cac8f4a3a3bb0b9e2bed
Diff: https://reviews.apache.org/r/67188/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
