----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67211/#review203443 -----------------------------------------------------------
Ship it! Haven't take a good at these but they might be candidates to use the new macros: ``` $ grep '(EXPECT\|ASSERT)_(TRUE\|FALSE)(.*is(Some\|Error\|None)())' 3rdparty/libprocess -r 3rdparty/libprocess/src/tests/state_machine_tests.cpp: EXPECT_TRUE(error.isError()); 3rdparty/libprocess/src/tests/state_machine_tests.cpp: EXPECT_TRUE(error.isError()); 3rdparty/libprocess/src/tests/state_machine_tests.cpp: ASSERT_TRUE(t->isError()); 3rdparty/libprocess/src/tests/state_machine_tests.cpp: EXPECT_TRUE(error.isError()); 3rdparty/libprocess/src/tests/state_machine_tests.cpp: EXPECT_TRUE(error.isError()); ``` We could fix them in a follow-up patch. - Chun-Hung Hsiao On May 18, 2018, 10:35 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67211/ > ----------------------------------------------------------- > > (Updated May 18, 2018, 10:35 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > Used `*_SOME` macro for checking `Try` values in libprocess. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/http_tests.cpp > 4661f2e332835b309b45d3a469324cad0f9684c1 > 3rdparty/libprocess/src/tests/jwt_tests.cpp > eb36a9aed3b11208c7cdc6f20b5347f46821a207 > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 24fe2208b3100faf0248f65594819014105a9494 > > > Diff: https://reviews.apache.org/r/67211/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
