> On May 18, 2018, 8:57 p.m., Chun-Hung Hsiao wrote:
> > Haven't take a good at these but they might be candidates to use the new
> > macros:
> > ```
> > $ grep '(EXPECT\|ASSERT)_(TRUE\|FALSE)(.*is(Some\|Error\|None)())'
> > 3rdparty/libprocess -r
> > 3rdparty/libprocess/src/tests/state_machine_tests.cpp:
> > EXPECT_TRUE(error.isError());
> > 3rdparty/libprocess/src/tests/state_machine_tests.cpp:
> > EXPECT_TRUE(error.isError());
> > 3rdparty/libprocess/src/tests/state_machine_tests.cpp:
> > ASSERT_TRUE(t->isError());
> > 3rdparty/libprocess/src/tests/state_machine_tests.cpp:
> > EXPECT_TRUE(error.isError());
> > 3rdparty/libprocess/src/tests/state_machine_tests.cpp:
> > EXPECT_TRUE(error.isError());
> > ```
> > We could fix them in a follow-up patch.
I have updated this patch to fix some of these as well. Note in general the fix
here does not apply to some checks we perform on `Result` values of the form
(EXPECT\|ASSERT)_TRUE(.*isError)
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67211/#review203443
-----------------------------------------------------------
On May 29, 2018, 10:13 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67211/
> -----------------------------------------------------------
>
> (Updated May 29, 2018, 10:13 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used `*_SOME` macro for checking `Try` values in libprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/http_tests.cpp
> 4661f2e332835b309b45d3a469324cad0f9684c1
> 3rdparty/libprocess/src/tests/jwt_tests.cpp
> f4b2c7cf3f685ae2730789db3a330ad0bc3b8d1b
> 3rdparty/libprocess/src/tests/ssl_tests.cpp
> 24fe2208b3100faf0248f65594819014105a9494
> 3rdparty/libprocess/src/tests/state_machine_tests.cpp
> 60e6b33718201bb3c1e7459859110bbc6352a2ff
>
>
> Diff: https://reviews.apache.org/r/67211/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
