-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67270/#review203676
-----------------------------------------------------------
Could you follow this up with a patch which compiles the example at least as
part of `check`?
For cmake we could e.g., add a `CMakeLists.txt` to the `example/` directory
with just
add_executable(example EXCLUDE_FROM_ALL example.cpp)
target_link_libraries(example process)
add_dependencies(libprocess-tests example)
and add the subdirectory to `libprocess/CMakeLists.txt`.
Similar for autotools.
Maybe we also should format the file according to our style guide in another
patch.
3rdparty/libprocess/examples/example.cpp
Line 68 (original), 68 (patched)
<https://reviews.apache.org/r/67270/#comment285958>
Could we fix the indention here?
- Benjamin Bannier
On May 23, 2018, 7:22 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67270/
> -----------------------------------------------------------
>
> (Updated May 23, 2018, 7:22 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The 'example.cpp' file in libprocess was missing the mandatory
> help string argument.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/examples/example.cpp
> a97665ee6b75c5b31397b5a10002fa23a7fe370a
>
>
> Diff: https://reviews.apache.org/r/67270/diff/1/
>
>
> Testing
> -------
>
> Compiled the `example.cpp` file.
>
>
> Thanks,
>
> Benno Evers
>
>
