> On May 25, 2018, 5:37 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/examples/example.cpp > > Lines 128-129 (original), 120-121 (patched) > > <https://reviews.apache.org/r/67270/diff/4/?file=2028088#file2028088line135> > > > > Without this `main` does nothing useful anymore, let's leave this in > > for now. > > Benno Evers wrote: > On the contrary, it runs a working HTTP server. If it's not commented > out, `main` immediately commits suicide, which imho hardly qualifies as > "doing something useful".
Makes sense. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67270/#review203886 ----------------------------------------------------------- On May 24, 2018, 3:33 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67270/ > ----------------------------------------------------------- > > (Updated May 24, 2018, 3:33 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > * Added the mandatory help string argument to calls > to 'route()', failing compilation. > > * The response returned from the '/vars' endpoint had > its 'type' field set to 'NONE', causing indefinite > hanging when trying to access the endpoint. Switched > to a constructor for OK that implicitly sets that field. > > * Removed a stray pid variable in main. > > * Added http:: namespace to disambiguate calls to 'post()'. > > * Commented out example code that commits instant > self-termination by default. > > > Diffs > ----- > > 3rdparty/libprocess/examples/example.cpp > 8c507aefa050543dfa6184626c494918c96d35e7 > > > Diff: https://reviews.apache.org/r/67270/diff/4/ > > > Testing > ------- > > Compiled the `example.cpp` file. > > > Thanks, > > Benno Evers > >
