----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67235/#review203702 -----------------------------------------------------------
src/master/metrics.cpp Lines 885 (patched) <https://reviews.apache.org/r/67235/#comment285980> If we increment for each resource in the offer, we'll end up incrementing multiple times when an offer contains multiple disk resources, for example. - Greg Mann On May 22, 2018, 10:47 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67235/ > ----------------------------------------------------------- > > (Updated May 22, 2018, 10:47 p.m.) > > > Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and > Vinod Kone. > > > Bugs: MESOS-8940 > https://issues.apache.org/jira/browse/MESOS-8940 > > > Repository: mesos > > > Description > ------- > > Added per-framework metrics for types of resources contained in offers. > > > Diffs > ----- > > src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e > src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b > src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 > src/tests/master_tests.cpp 6a0fa988aebaf1cf66abaaca0c628f981c6ccc31 > > > Diff: https://reviews.apache.org/r/67235/diff/3/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
