----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65665/#review203901 -----------------------------------------------------------
Fix it, then Ship it! src/resource_provider/storage/provider.cpp Lines 3446 (patched) <https://reviews.apache.org/r/65665/#comment286268> operationTypes src/resource_provider/storage/provider.cpp Lines 3463 (patched) <https://reviews.apache.org/r/65665/#comment286269> Does this compile? - Jie Yu On May 24, 2018, 3:19 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65665/ > ----------------------------------------------------------- > > (Updated May 24, 2018, 3:19 a.m.) > > > Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan > Schlicht. > > > Bugs: MESOS-8383 > https://issues.apache.org/jira/browse/MESOS-8383 > > > Repository: mesos > > > Description > ------- > > This patch adds `operations_pending`, `operations_finished`, > `operations_failed`, and `operations_dropped` metrics to count the > occurances of these operation states. > > Additionally, An error log in `_applyOperation()` is removed because the > error is already logged at the call site. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180 > > > Diff: https://reviews.apache.org/r/65665/diff/11/ > > > Testing > ------- > > sudo make check > A unit test is added in the next patch in chain. > > > Thanks, > > Chun-Hung Hsiao > >
