----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67390/#review204207 -----------------------------------------------------------
3rdparty/libprocess/src/libwinio_io.cpp Lines 47 (patched) <https://reviews.apache.org/r/67390/#comment286611> I am not sure what the rules are, but since this is retruning WindowsError and making calls to the windows namespace, should this be in stout? - Radhika Jandhyala On May 30, 2018, 6:46 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67390/ > ----------------------------------------------------------- > > (Updated May 30, 2018, 6:46 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-8668, MESOS-8671 and MESOS-8672 > https://issues.apache.org/jira/browse/MESOS-8668 > https://issues.apache.org/jira/browse/MESOS-8671 > https://issues.apache.org/jira/browse/MESOS-8672 > > > Repository: mesos > > > Description > ------- > > The libprocess eventloops are used to implement the `EventLoop`, > SocketImpl` and `io::read/write` interfaces. Thus, by providing those > implementations using libwinio, libprocess now supports the libwinio > backend. > > > Diffs > ----- > > 3rdparty/libprocess/src/libwinio.hpp PRE-CREATION > 3rdparty/libprocess/src/libwinio_eventloop.cpp PRE-CREATION > 3rdparty/libprocess/src/libwinio_io.cpp PRE-CREATION > 3rdparty/libprocess/src/libwinio_socket.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/67390/diff/1/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
