----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67390/#review204503 -----------------------------------------------------------
3rdparty/libprocess/src/libwinio_eventloop.cpp Lines 52-73 (patched) <https://reviews.apache.org/r/67390/#comment287012> I know this code exists elsewhere too... we should refactor into a stout function. 3rdparty/libprocess/src/libwinio_io.cpp Lines 78-101 (patched) <https://reviews.apache.org/r/67390/#comment287013> Wait... doesn't this belong in the `prepare_async` from earlier? Did something get moved? 3rdparty/libprocess/src/libwinio_socket.cpp Lines 16-18 (patched) <https://reviews.apache.org/r/67390/#comment287014> Huh? Isn't this file called `libWINio_socket.cpp`? 3rdparty/libprocess/src/libwinio_socket.cpp Lines 100-102 (patched) <https://reviews.apache.org/r/67390/#comment287016> I think you want a `WindowsError error; ... + error.message`. Otherwise it's just going to print `socket: 3` or whatever. 3rdparty/libprocess/src/libwinio_socket.cpp Lines 105 (patched) <https://reviews.apache.org/r/67390/#comment287015> What is it, and why? 3rdparty/libprocess/src/libwinio_socket.cpp Lines 147 (patched) <https://reviews.apache.org/r/67390/#comment287017> What does that mean? 3rdparty/libprocess/src/libwinio_socket.cpp Lines 176 (patched) <https://reviews.apache.org/r/67390/#comment287018> This code looks very... reused. Nothing necessarily wrong with that, but should we reduce it at all? - Andrew Schwartzmeyer On May 30, 2018, 11:46 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67390/ > ----------------------------------------------------------- > > (Updated May 30, 2018, 11:46 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-8668, MESOS-8671 and MESOS-8672 > https://issues.apache.org/jira/browse/MESOS-8668 > https://issues.apache.org/jira/browse/MESOS-8671 > https://issues.apache.org/jira/browse/MESOS-8672 > > > Repository: mesos > > > Description > ------- > > The libprocess eventloops are used to implement the `EventLoop`, > SocketImpl` and `io::read/write` interfaces. Thus, by providing those > implementations using libwinio, libprocess now supports the libwinio > backend. > > > Diffs > ----- > > 3rdparty/libprocess/src/libwinio.hpp PRE-CREATION > 3rdparty/libprocess/src/libwinio_eventloop.cpp PRE-CREATION > 3rdparty/libprocess/src/libwinio_io.cpp PRE-CREATION > 3rdparty/libprocess/src/libwinio_socket.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/67390/diff/1/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
