----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67223/#review204368 -----------------------------------------------------------
Ship it! This patch needs to be rebased, but LGTM. src/csi/client.cpp Line 59 (original), 64 (patched) <https://reviews.apache.org/r/67223/#comment286838> Nit: Might as well rewrap like all other function bodies. src/csi/client.cpp Line 227 (original), 256 (patched) <https://reviews.apache.org/r/67223/#comment286839> Nit: Rewrap? - Benjamin Bannier On May 19, 2018, 1:34 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67223/ > ----------------------------------------------------------- > > (Updated May 19, 2018, 1:34 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Zhitao Li. > > > Bugs: MESOS-8924 > https://issues.apache.org/jira/browse/MESOS-8924 > > > Repository: mesos > > > Description > ------- > > This patch takes the advantages of the moving constructors of the CSI > request protobuf messages to avoid copying the messages. > > > Diffs > ----- > > src/csi/client.hpp 5d846740f72125efb3654e14d763bd24634367b9 > src/csi/client.cpp 559e8057eccce5bf758918c24e5ca8c561af6592 > src/resource_provider/storage/provider.cpp > 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180 > src/tests/csi_client_tests.cpp f5b9eac38a4079cc2873ce2e2de24eaf315e0bc9 > > > Diff: https://reviews.apache.org/r/67223/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
