----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67223/#review204480 -----------------------------------------------------------
Patch looks great! Reviews applied: [67164, 67190, 67191, 67154, 67155, 67156, 67158, 67157, 67223] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 8, 2018, 1:31 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67223/ > ----------------------------------------------------------- > > (Updated June 8, 2018, 1:31 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Zhitao Li. > > > Bugs: MESOS-8924 > https://issues.apache.org/jira/browse/MESOS-8924 > > > Repository: mesos > > > Description > ------- > > This patch takes the advantages of the moving constructors of the CSI > request protobuf messages to avoid copying the messages. > > > Diffs > ----- > > src/csi/client.hpp 1c57ac52ade6295d5c45ac8a439ea572d16d7ae3 > src/csi/client.cpp 923ee6f85dc8070d60bee9834846f859883c73df > src/resource_provider/storage/provider.cpp > 333336e9109d8cdc7fc1fa29582e2717b84e3e60 > > > Diff: https://reviews.apache.org/r/67223/diff/3/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
