----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67356/#review204650 -----------------------------------------------------------
Patch looks great! Reviews applied: [67354, 67355, 67356] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 29, 2018, 7:21 a.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67356/ > ----------------------------------------------------------- > > (Updated May 29, 2018, 7:21 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent > huang, Ilya Pronin, and James Peach. > > > Bugs: MESOS-3475 > https://issues.apache.org/jira/browse/MESOS-3475 > > > Repository: mesos > > > Description > ------- > > This patch removes `os::setenv()`, `os::unsetenv()` calls that are > currently used to implicitly configure both `MesosExecutorDriver` and > v1 Executor via global environment variables. This change prepares a > map containing modified environment and passes it to a constructor of > an executor. > > > Diffs > ----- > > src/tests/containerizer.cpp c4e18b7c5d6937f53f806e94a40c969cdcac79eb > src/tests/mesos.hpp 733344a2f07ebd9d841a55fb9bbfda2e3c1a1eb2 > > > Diff: https://reviews.apache.org/r/67356/diff/2/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >
