----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67356/#review204784 -----------------------------------------------------------
PASS: Mesos patch 67356 was successfully built and tested. Reviews applied: `['67354', '67355', '67356']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67356 - Mesos Reviewbot Windows On May 29, 2018, 2:21 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67356/ > ----------------------------------------------------------- > > (Updated May 29, 2018, 2:21 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent > huang, Ilya Pronin, and James Peach. > > > Bugs: MESOS-3475 > https://issues.apache.org/jira/browse/MESOS-3475 > > > Repository: mesos > > > Description > ------- > > This patch removes `os::setenv()`, `os::unsetenv()` calls that are > currently used to implicitly configure both MesosExecutorDriver and > v1 Executor via global environment variables. This change prepares a > map containing modified environment and passes it to a constructor of > an executor. > > > Diffs > ----- > > src/tests/containerizer.cpp c4e18b7c5d6937f53f806e94a40c969cdcac79eb > > > Diff: https://reviews.apache.org/r/67356/diff/5/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >
