----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65975/#review204920 -----------------------------------------------------------
Fix it, then Ship it! src/resource_provider/storage/provider.cpp Lines 1312 (patched) <https://reviews.apache.org/r/65975/#comment287724> We could break after `return` for readability. src/resource_provider/storage/provider.cpp Line 2927 (original), 2974 (patched) <https://reviews.apache.org/r/65975/#comment287726> We can codify this comment, CHECK(!protobuf::isSpeculativeOperation(operation.info())) << "Operation " << operation << " is speculative"; - Benjamin Bannier On June 14, 2018, 2:06 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65975/ > ----------------------------------------------------------- > > (Updated June 14, 2018, 2:06 a.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-8825 > https://issues.apache.org/jira/browse/MESOS-8825 > > > Repository: mesos > > > Description > ------- > > The storage pools needs to be reconciled in the following two scenarios: > > 1. When there is a change in the set of known profiles. > 2. When a volume/block of an unknown profile is destroyed, because the > disk space being freed up may belong to a known profile. > > This patch adds a sequence to coordinate the reconciliations for the > above two cases. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > b90a4b81838fec410a97a10ce44a811bb81c87eb > > > Diff: https://reviews.apache.org/r/65975/diff/5/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
