> On April 20, 2018, 3:27 p.m., Benjamin Bannier wrote: > > First round of reviews. > > > > I am not a big fan on how reconcilations are modelled here. The counting > > seems to lead to an incomplete encapsulation of correct behavior. I'd much > > rather see standard `libprocess` actor semantics and better use of data > > structures instead. Right now the code appears too complicated and > > potentially brittle to the touch to me.
I am nto sure what a good example of a solution would, but have a look at e.g., the master registrar in how it pushes updates (operations) into a simple `deque` which it then works on sequentially. While it triggers work on the updates manually the control flow is easier to see (still not easy enough though). Maybe we have other examples as well. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65975/#review201629 ----------------------------------------------------------- On April 12, 2018, 5:36 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65975/ > ----------------------------------------------------------- > > (Updated April 12, 2018, 5:36 a.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-8492 > https://issues.apache.org/jira/browse/MESOS-8492 > > > Repository: mesos > > > Description > ------- > > The storage pools needs to be reconciled in the following two scenarios: > > 1. When there is a change in the set of known profiles. > 2. When a volume/block of an unknown profile is destroyed, because the > disk space being freed up may belong to a known profile. > > This patch adds a sequence to coordinate the reconciliations for the > above two cases. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > a07620d1c4bf618f669575b3e183bf598da905a6 > > > Diff: https://reviews.apache.org/r/65975/diff/4/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
