----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67666/#review205056 -----------------------------------------------------------
Fix it, then Ship it! src/tests/disk_profile_server.hpp Lines 34-35 (patched) <https://reviews.apache.org/r/67666/#comment287996> Nit: This class doesn't really fetch, but instead provides a mock remote. src/tests/disk_profile_server.hpp Lines 43 (patched) <https://reviews.apache.org/r/67666/#comment287964> Why is this needed? src/tests/disk_profile_server.hpp Lines 62 (patched) <https://reviews.apache.org/r/67666/#comment287994> `Owned` cannot be copied (e.g., into the lambda below), we should probably use a `shared_ptr` here. Unfortunately this implementation detail would leak into the return value, but it is the correct thing to do I belive. src/tests/disk_profile_server.hpp Lines 74 (patched) <https://reviews.apache.org/r/67666/#comment287963> Either make this a `std::unique_ptr` or make the class non-copyable (we should reference MESOS-5122 in that case). - Benjamin Bannier On June 20, 2018, 7:33 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67666/ > ----------------------------------------------------------- > > (Updated June 20, 2018, 7:33 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, Joseph Wu, and Jan > Schlicht. > > > Bugs: MESOS-8995 > https://issues.apache.org/jira/browse/MESOS-8995 > > > Repository: mesos > > > Description > ------- > > This helper class will be used to test functionalities related to > profile changes. > > > Diffs > ----- > > src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 > src/tests/disk_profile_adaptor_tests.cpp > 4485f1635f484ce6e1c7c532eedb277f5eee118b > src/tests/disk_profile_server.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/67666/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
