> On June 20, 2018, 11:01 a.m., Benjamin Bannier wrote: > > src/tests/disk_profile_server.hpp > > Lines 34-35 (patched) > > <https://reviews.apache.org/r/67666/diff/1/?file=2042685#file2042685line34> > > > > Nit: This class doesn't really fetch, but instead provides a mock > > remote.
It's a helper for "module configured to fetch from HTTP URIs", not "helper to fetch from HTTP URIs". I copied this from Joseph's comments, but TBH its not nontrivial for me to parse this sentence lol. I'll simplify the comment. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67666/#review205056 ----------------------------------------------------------- On June 20, 2018, 5:33 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67666/ > ----------------------------------------------------------- > > (Updated June 20, 2018, 5:33 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, Joseph Wu, and Jan > Schlicht. > > > Bugs: MESOS-8995 > https://issues.apache.org/jira/browse/MESOS-8995 > > > Repository: mesos > > > Description > ------- > > This helper class will be used to test functionalities related to > profile changes. > > > Diffs > ----- > > src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 > src/tests/disk_profile_adaptor_tests.cpp > 4485f1635f484ce6e1c7c532eedb277f5eee118b > src/tests/disk_profile_server.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/67666/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
