> On June 20, 2018, 12:58 a.m., Qian Zhang wrote: > > src/slave/containerizer/docker.hpp > > Lines 140 (patched) > > <https://reviews.apache.org/r/53105/diff/5/?file=2014848#file2014848line140> > > > > It seems the convention in Mesos is to implement a `struct Metrics` for > > all the metrics rather than directly adding the metric here. And the name > > of the metric should be in underscore_case instead of camelCase, so I would > > suggest to name it `image_pull("containerizer/docker/image_pull", > > Hours(1))`. > > > > And is 1 hour too short for this metric?
Ack for name and metrics struct On window: In our operational experience, if something goes wrong on the docker registry side, we typicaly detect that within an hour or so, so I would not make this much longer and lose sensitivity. If anyone needs a longer view, they can usually pipe the metric into another time series database and perform out of bound aggregation from there. - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53105/#review205049 ----------------------------------------------------------- On May 21, 2018, 10:16 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53105/ > ----------------------------------------------------------- > > (Updated May 21, 2018, 10:16 a.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Qian Zhang. > > > Bugs: MESOS-6451 > https://issues.apache.org/jira/browse/MESOS-6451 > > > Repository: mesos > > > Description > ------- > > Added an hourly timer for `slave/docker_containerizer/pull`. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 6bdf4c7f60384473927de437a061fafe94170557 > src/slave/containerizer/docker.cpp a4c9c10e91e75f406329cbb2086f39b549cbeed0 > > > Diff: https://reviews.apache.org/r/53105/diff/5/ > > > Testing > ------- > > Ran `mesos-execute` with a docker image and docker containerizer, observed > the following metrics: > ``` > curl -s localhost:5051/metrics/snapshot | jq . | grep pull > "containerizer/docker/pull_ms/p999": 26209.36173824, > "containerizer/docker/pull_ms/p90": 21036.405248, > "containerizer/docker/pull_ms/p9999": 26256.388615424, > "containerizer/docker/pull_ms/p50": 135.570944, > "containerizer/docker/pull_ms/max": 26261.613824, > "containerizer/docker/pull_ms/p95": 23649.009536, > "containerizer/docker/pull_ms/min": 103.215872, > "containerizer/docker/pull_ms/p99": 25739.0929664, > "containerizer/docker/pull_ms": 26261.613824, > "containerizer/docker/pull_ms/count": 3 > ``` > > > Thanks, > > Zhitao Li > >
