> On June 20, 2018, 1:54 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/uri_disk_profile_adaptor.hpp > > Lines 242 (patched) > > <https://reviews.apache.org/r/67663/diff/1/?file=2042676#file2042676line243> > > > > Is this field needed for a later change? It looks like it should be > > fine to just remove entries from `profileMatrix` and then drive logic with > > e.g., `contains` checks. > > Chun-Hung Hsiao wrote: > The profile data is kept in `profileMatrix` even for inactive profiles > because I'd like to have a best-effort check on the profile immutability, > i.e., if the profile is removed and added back, its capability and parameters > should remain the same. > > There's a related TODO to consider checkpointing `profileMatrix` to make > the check more robust.
In fact, the following unit test is changed to test this: "profile" is missing in the second poll, but appeared in the third one (with a mutated capability) and the fourth one (with the same capability). The third poll is ignored but the fourth one is taken. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67663/#review205073 ----------------------------------------------------------- On June 20, 2018, 5:32 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67663/ > ----------------------------------------------------------- > > (Updated June 20, 2018, 5:32 a.m.) > > > Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and > Joseph Wu. > > > Bugs: MESOS-8825 > https://issues.apache.org/jira/browse/MESOS-8825 > > > Repository: mesos > > > Description > ------- > > Now the `UriDiskProfileAdaptor` module can handle disappeared profiles > when polling the profile matrix, and performs a best-effort immutability > check for reappeared profiles. > > > Diffs > ----- > > src/resource_provider/storage/uri_disk_profile_adaptor.hpp > 0484933b42d0bd66c689b06cb48f492eef7bc606 > src/resource_provider/storage/uri_disk_profile_adaptor.cpp > 614590ef7d1c0cc1df99b8e57c7fbd496793b5a7 > src/tests/disk_profile_adaptor_tests.cpp > 4485f1635f484ce6e1c7c532eedb277f5eee118b > > > Diff: https://reviews.apache.org/r/67663/diff/1/ > > > Testing > ------- > > sudo make check > > A end-to-end test will be added later in the chain. > > > Thanks, > > Chun-Hung Hsiao > >
