> On July 10, 2018, 4:02 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/uri_disk_profile_adaptor.cpp > > Line 248 (original), 244 (patched) > > <https://reviews.apache.org/r/67663/diff/2/?file=2043782#file2043782line256> > > > > `foreachpair` would give us a way to give better names to `first` and > > `second`.
`foreachpair` does not work for `google::protobuf::Map` hence `foreach`. Dropping. > On July 10, 2018, 4:02 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/uri_disk_profile_adaptor.cpp > > Line 292 (original), 281 (patched) > > <https://reviews.apache.org/r/67663/diff/2/?file=2043782#file2043782line300> > > > > Use `contains` here. `parsed.profile_matrix()` is a `google::protobuf::Map` hence no `contains`. Dropping. > On July 10, 2018, 4:02 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/uri_disk_profile_adaptor.cpp > > Lines 291 (patched) > > <https://reviews.apache.org/r/67663/diff/2/?file=2043782#file2043782line310> > > > > `foreachpair` would give us a way to give better names to `first` and > > `second`. `foreachpair` does not work for `google::protobuf::Map` hence `foreach`. Dropping. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67663/#review205914 ----------------------------------------------------------- On June 21, 2018, 4:27 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67663/ > ----------------------------------------------------------- > > (Updated June 21, 2018, 4:27 a.m.) > > > Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and > Joseph Wu. > > > Bugs: MESOS-8825 > https://issues.apache.org/jira/browse/MESOS-8825 > > > Repository: mesos > > > Description > ------- > > Now the `UriDiskProfileAdaptor` module can handle disappeared profiles > when polling the profile matrix, and performs a best-effort immutability > check for reappeared profiles. > > > Diffs > ----- > > src/resource_provider/storage/uri_disk_profile_adaptor.hpp > 0484933b42d0bd66c689b06cb48f492eef7bc606 > src/resource_provider/storage/uri_disk_profile_adaptor.cpp > 614590ef7d1c0cc1df99b8e57c7fbd496793b5a7 > src/tests/disk_profile_adaptor_tests.cpp > 4485f1635f484ce6e1c7c532eedb277f5eee118b > > > Diff: https://reviews.apache.org/r/67663/diff/2/ > > > Testing > ------- > > sudo make check > > A end-to-end test will be added later in the chain. > > > Thanks, > > Chun-Hung Hsiao > >
