> On June 20, 2018, 1:14 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 1066 (patched) > > <https://reviews.apache.org/r/67670/diff/1/?file=2042689#file2042689line1066> > > > > Why is this required? It looks like this is the only driver for making > > this a `ROOT` test. If it is required we should document why; else let's > > make this a non-`ROOT` test. > > > > nit: We can remove the empty line below. > > Benjamin Bannier wrote: > Did you make any changes for this in rev2? Reopening for easier tracking. > > Chun-Hung Hsiao wrote: > Created https://issues.apache.org/jira/browse/MESOS-9016 for this.
I forgot to sent out the reply yesterday :( - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67670/#review205061 ----------------------------------------------------------- On June 21, 2018, 5:02 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67670/ > ----------------------------------------------------------- > > (Updated June 21, 2018, 5:02 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-8995 > https://issues.apache.org/jira/browse/MESOS-8995 > > > Repository: mesos > > > Description > ------- > > The `ROOT_ProfileDisappeared` tests if a `CREATE_VOLUME` consuming a RAW > disk with a disappeared profile will be dropped, and if the disk space > freed by a `DESTROY_VOLUME` destroying a volume with a disappeared > profile will be recovered with a newly appeared profile. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > 1afe8a8e0413ef225e952cd9cd6376e5d82774e5 > > > Diff: https://reviews.apache.org/r/67670/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
