> On July 10, 2018, 3:37 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 1212-1217 (patched) > > <https://reviews.apache.org/r/67670/diff/2/?file=2043805#file2043805line1212> > > > > Shouldn't we update before we poll?
I advance the clock first to make sure that there is only one poll. Otherwise there might be a race condition and the advance might generate an additional call. Let me add some comments about it. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67670/#review205912 ----------------------------------------------------------- On June 21, 2018, 5:02 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67670/ > ----------------------------------------------------------- > > (Updated June 21, 2018, 5:02 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-8995 > https://issues.apache.org/jira/browse/MESOS-8995 > > > Repository: mesos > > > Description > ------- > > The `ROOT_ProfileDisappeared` tests if a `CREATE_VOLUME` consuming a RAW > disk with a disappeared profile will be dropped, and if the disk space > freed by a `DESTROY_VOLUME` destroying a volume with a disappeared > profile will be recovered with a newly appeared profile. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > 1afe8a8e0413ef225e952cd9cd6376e5d82774e5 > > > Diff: https://reviews.apache.org/r/67670/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
