----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67832/#review205738 -----------------------------------------------------------
PASS: Mesos patch 67832 was successfully built and tested. Reviews applied: `['67832']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67832 - Mesos Reviewbot Windows On July 5, 2018, 9:16 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67832/ > ----------------------------------------------------------- > > (Updated July 5, 2018, 9:16 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > The docker executor used the command line subprocess form even it only > ever called the docker executable. The command line form made the > executor fail if the `--docker=` path contained spaces. > > > Diffs > ----- > > src/docker/docker.hpp 25d9ca662fa5d99b32c668a5fdfc75584132cc38 > src/docker/docker.cpp baac70f25ef3f944541341822aacb6a395853113 > src/tests/containerizer/docker_tests.cpp > 7097efc716ab0e1f34d5a1a35d8e0e173b113c91 > > > Diff: https://reviews.apache.org/r/67832/diff/1/ > > > Testing > ------- > > Tested by running `HungDockerTest` on a path with a space. Waiting for > Windows CI for verification. > On Linux, ran mesos-tests. > > > Thanks, > > Akash Gupta > >
