----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67832/#review205873 -----------------------------------------------------------
Fix it, then Ship it! src/docker/docker.cpp Lines 196-198 (original), 198-201 (patched) <https://reviews.apache.org/r/67832/#comment288773> Nit: for here and below, if `cmd` is only being used in the information and error messages, do it inline to (a) avoid constructing the string if there was no error and (b) avoid a future programmer going and using `cmd` again in the `subprocess` call because they thought it was silly. src/tests/containerizer/docker_tests.cpp Lines 401 (patched) <https://reviews.apache.org/r/67832/#comment288774> Is the test fixture's sandbox not available? - Andrew Schwartzmeyer On July 5, 2018, 2:16 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67832/ > ----------------------------------------------------------- > > (Updated July 5, 2018, 2:16 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > The docker executor used the command line subprocess form even it only > ever called the docker executable. The command line form made the > executor fail if the `--docker=` path contained spaces. > > > Diffs > ----- > > src/docker/docker.hpp 25d9ca662fa5d99b32c668a5fdfc75584132cc38 > src/docker/docker.cpp baac70f25ef3f944541341822aacb6a395853113 > src/tests/containerizer/docker_tests.cpp > 7097efc716ab0e1f34d5a1a35d8e0e173b113c91 > > > Diff: https://reviews.apache.org/r/67832/diff/1/ > > > Testing > ------- > > Tested by running `HungDockerTest` on a path with a space. Waiting for > Windows CI for verification. > On Linux, ran mesos-tests. > > > Thanks, > > Akash Gupta > >
