----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67693/#review205755 -----------------------------------------------------------
src/master/http.cpp Lines 3821 (patched) <https://reviews.apache.org/r/67693/#comment288625> Do we want to: 1. Simply skip such operations, as suggested in the code here, or 2. Return an `InternalServerError` eventually, or 3. Just `CHECK` that this shouldn't happen? Ditto below. Please feel free to drop this if you think skipping is good enough. src/tests/api_tests.cpp Lines 131-134 (original), 131-134 (patched) <https://reviews.apache.org/r/67693/#comment288665> How about making the same change as you did in `AgentAPITest::post`? ``` Future<v1::master::Response> post( const process::PID<master::Master>& pid, const v1::master::Call& call, const ContentType& contentType, const Credential& credential = DEFAULT_CREDENTIAL) ``` src/tests/api_tests.cpp Lines 1015-1020 (patched) <https://reviews.apache.org/r/67693/#comment288658> Do we need this? src/tests/api_tests.cpp Lines 1149-1167 (patched) <https://reviews.apache.org/r/67693/#comment288667> If you change the `MasterAPITest::post` helper, we can use it here: ``` v1Response = post(master.get()->pid, v1Call, contentType, DEFAULT_CREDENTIAL_2) .then(...); ``` src/tests/api_tests.cpp Lines 7102-7107 (patched) <https://reviews.apache.org/r/67693/#comment288669> Do we need this? src/tests/api_tests.cpp Lines 7225-7243 (patched) <https://reviews.apache.org/r/67693/#comment288666> We can use the `AgentAPITest::post` helper here: ``` v1Response = post(agent.get()->pid, v1Call, contentType, DEFAULT_CREDENTIAL_2); ``` - Chun-Hung Hsiao On June 21, 2018, 3:53 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67693/ > ----------------------------------------------------------- > > (Updated June 21, 2018, 3:53 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Bugs: MESOS-8473 > https://issues.apache.org/jira/browse/MESOS-8473 > > > Repository: mesos > > > Description > ------- > > This patch adds filtering of operations reported for `GET_OPERATIONS` > calls. A principal is allowed to view see all operations for which it > is allowed to see the role of the underlying resources. > > > Diffs > ----- > > src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5 > src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c > src/tests/api_tests.cpp 4d6b5b3e938faed934e875e23e29c67fd50b9d6f > > > Diff: https://reviews.apache.org/r/67693/diff/3/ > > > Testing > ------- > > `make check` > > The added tests fails without the corresponding changes to the master and > agent code. > > > Thanks, > > Benjamin Bannier > >
