----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67890/ -----------------------------------------------------------
Review request for mesos and Greg Mann. Repository: mesos Description ------- When adding / removing metrics, we were performing double lookups on the metrics map. Removing these provides a slight performance improvement. Diffs ----- 3rdparty/libprocess/src/metrics/metrics.cpp 4883c9acaa0cc568e27944661a8208f7b2a356a1 Diff: https://reviews.apache.org/r/67890/diff/1/ Testing ------- Before: ``` Added 100000 counters in 2.455274623secs Snapshot of 100000 counters in 809.816666ms HTTP /snapshot of 100000 counters in 1.739941138secs Removed 100000 counters in 3.31390385secs ``` After: ``` Added 100000 counters in 1.954696011secs Snapshot of 100000 counters in 826.540283ms HTTP /snapshot of 100000 counters in 1.775644115secs Removed 100000 counters in 2.404567921secs ``` Thanks, Benjamin Mahler
