----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67891/#review206014 -----------------------------------------------------------
Thanks for adding this! docs/app-framework-development-guide.md Lines 52-53 (patched) <https://reviews.apache.org/r/67891/#comment288966> We probably also want to point out that, since offered resources are counted as allocated from the allocator perspective, declining quickly could also increase the chance that the framework will get a usable offer soon. docs/app-framework-development-guide.md Lines 59-75 (patched) <https://reviews.apache.org/r/67891/#comment288967> These should (also) be in "Operational Guide" (or at least link to there). docs/app-framework-development-guide.md Lines 60 (patched) <https://reviews.apache.org/r/67891/#comment288968> "Competing" may imply over-subscribed (thus operator with under-subscribed cluster may ignore), how about just "sharing the cluster" or "co-existing with other scheudlers". docs/app-framework-development-guide.md Lines 70-71 (patched) <https://reviews.apache.org/r/67891/#comment288969> "If running an undercommitted cluster, then DRF is not needed." I suggest to remove this, it is not entirely true and definitely not easy for the operators to understand. docs/app-framework-development-guide.md Lines 70-74 (patched) <https://reviews.apache.org/r/67891/#comment288970> I think it is not easy to explain the starvation issue in a few words. How about providing a link to the doc or the ticket about starvation as optional furhter reading for sophisticated readers. docs/app-framework-development-guide.md Lines 73-74 (patched) <https://reviews.apache.org/r/67891/#comment288971> add "weighted"? so that readers know they could set weights for random sorter as well? - Meng Zhu On July 11, 2018, 8:33 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67891/ > ----------------------------------------------------------- > > (Updated July 11, 2018, 8:33 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-8238 > https://issues.apache.org/jira/browse/MESOS-8238 > > > Repository: mesos > > > Description > ------- > > Running multiple frameworks requires co-operation from framework > developers; this outlines some initial guidelines that should be > followed to ensure running multiple frameworks together performs > well. > > > Diffs > ----- > > docs/app-framework-development-guide.md > 035ac1f80e063c75786845475d573c1ee03570c0 > > > Diff: https://reviews.apache.org/r/67891/diff/1/ > > > Testing > ------- > > N/A > > > Thanks, > > Benjamin Mahler > >
