----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/#review206157 -----------------------------------------------------------
There is still more to review... I'll get to it. include/mesos/docker/spec.hpp Lines 124-126 (patched) <https://reviews.apache.org/r/67931/#comment289057> I think this and the commit before need to be re-ordered, as this commit is introducing logic required and used by the previous commit. include/mesos/docker/spec.hpp Lines 141 (patched) <https://reviews.apache.org/r/67931/#comment289058> Dumb question, but is there an S1/S2 for V1 as well? include/mesos/docker/spec.hpp Lines 141-164 (patched) <https://reviews.apache.org/r/67931/#comment289060> I'm not sure, but would this be better as a variant? ``` std::unique_ptr<Variant<v1::ImageManifest, v2::ImageManifest, v2_2::ImageManifest>> manifest; ``` (Declared at point of use.) P.S. Why do we need pointers? include/mesos/uri/fetcher.hpp Lines 84-96 (patched) <https://reviews.apache.org/r/67931/#comment289059> Maybe add to this comment (and the one below) that this is used by the V2_S2 schema. src/docker/spec.cpp Lines 390-426 (patched) <https://reviews.apache.org/r/67931/#comment289061> I think you'd get all of this for "free" out of a variant. src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp Lines 467 (patched) <https://reviews.apache.org/r/67931/#comment289062> Why do we need a `shared_ptr` here? src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp Lines 473 (patched) <https://reviews.apache.org/r/67931/#comment289064> Heyyy what is this... src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp Lines 490 (patched) <https://reviews.apache.org/r/67931/#comment289063> Why are we making this on the heap and using a pointer? src/uri/fetcher.cpp Line 56 (original), 56 (patched) <https://reviews.apache.org/r/67931/#comment289065> We can delete this now! Also, add `MESOS-8570` to the "bug" field of this review, and let's get you a JIRA account so I can assign it to you. src/uri/fetcher.cpp Lines 88 (patched) <https://reviews.apache.org/r/67931/#comment289066> Why does this function throw away `urls`? - Andrew Schwartzmeyer On July 16, 2018, 11:35 a.m., Liangyu Zhao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67931/ > ----------------------------------------------------------- > > (Updated July 16, 2018, 11:35 a.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Support parsing schema 2 and fetching blob with multiple URLs as > specified in schema 2. Update `curl` version to 7.60.0 because of bug > encountered in version 7.57.0. > > > Diffs > ----- > > 3rdparty/cmake/Versions.cmake 0a897d808cd9e05ac0d1a4e1ca61b8f3538f0c4a > include/mesos/docker/spec.hpp 2879414dc42ffe633ac74b51e1bb116698c41162 > include/mesos/docker/v2_2.hpp PRE-CREATION > include/mesos/docker/v2_2.proto PRE-CREATION > include/mesos/uri/fetcher.hpp 760d6b33234d8efdc533c0c6f05e83a5c7d1f56b > src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5 > src/Makefile.am 228e168c22f3fd0367f029c506171c6979b31c07 > src/docker/spec.cpp 96fbf1f9cf1c2c4b2383607a97990f3a9156e6d9 > src/slave/containerizer/mesos/containerizer.cpp > 98129d006cda9b65804b518619b6addc8990410a > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > a5683e3fe15dd35596122fcc0c580ae9d3adf7f2 > src/uri/fetcher.hpp fbf64c6767dea3aa0798f68db8322ce47cd8ad36 > src/uri/fetcher.cpp 489c7ce0198ee6803dcc8eb9710b292fa743a0e8 > src/uri/fetchers/docker.hpp cdbab9a5684a68a729be12bc06d331acca137da5 > src/uri/fetchers/docker.cpp 55ca118660872a933a2dc186723bec6a39ee80f7 > > > Diff: https://reviews.apache.org/r/67931/diff/1/ > > > Testing > ------- > > > Thanks, > > Liangyu Zhao > >
